Skip to content

Conversation

@eveleighoj
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

currently there is a hidden dependency between transformation and dataset creation. Specifically the parquet fies that are created, they are not uploaded to s3 and their location is not explicitly set in thte dataset create command they're just expected to be in another directory.

Related Tickets & Documents

  • Ticket Link
  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

@eveleighoj
Copy link
Contributor Author

Notes on tests to write:

  • after first push the output_path provided isn't a path object so it errors but there's no tests that highlight this. need to add tests to check that when it's ran from the cli it works as otherwise it will error worth also checking to see if click.Path() converts it and when is it a string again.

@eveleighoj eveleighoj marked this pull request as ready for review December 29, 2025 18:56
@eveleighoj eveleighoj merged commit e1fb74d into main Dec 30, 2025
4 checks passed
@eveleighoj eveleighoj deleted the feat/move_parquet branch December 30, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants