Add files via upload#5
Open
grotius-cnc wants to merge 2 commits intodillonhuff:masterfrom
grotius-cnc:master
Open
Add files via upload#5grotius-cnc wants to merge 2 commits intodillonhuff:masterfrom grotius-cnc:master
grotius-cnc wants to merge 2 commits intodillonhuff:masterfrom
grotius-cnc:master
Conversation
dillonhuff
reviewed
Jun 30, 2021
|
|
||
| for(int chunk=0; chunk<p.get_block(i).size(); chunk++){ | ||
|
|
||
| /* |
Owner
There was a problem hiding this comment.
Could you remove this commented out block of code?
Author
There was a problem hiding this comment.
That is nice reference (debug) code. I would prefer it stay's there for info.
src/interface.h
Outdated
| { | ||
| public: | ||
| interface(); | ||
| void read_gcode_file(std::string filename); |
Owner
There was a problem hiding this comment.
The only effect of this function seems to be to print out the file. It is a useful function, but perhaps you could name it something more descriptive like pretty_print_gcode_file?
Author
There was a problem hiding this comment.
Hi, i have attached a doxygen compatible comment above line 12. Hope this is ok for you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this interface could be helpfull.