Jeff/fix/connect#23
Closed
spomichter wants to merge 30 commits into
Closed
Conversation
…PC proxy When --connect is provided (with optional URL), the viewer connects to an existing gRPC proxy server instead of spawning its own. This mirrors the stock rerun binary's --connect behavior. Defaults to rerun+http://127.0.0.1:<port>/proxy.
- Remove unused `parking_lot` dependency (cargo-shear) - Add `[lints] workspace = true` to dimos/Cargo.toml (rerun lint) - Fix TOML formatting in dimos/pyproject.toml (taplo) - Rename error variables from `e` to `err` (rerun lint convention) - Fix trailing whitespace in keyboard.rs - Add blank lines before doc comments on struct fields/constants - Use Display instead of Debug for error formatting in viewer.rs - Commit updated Cargo.lock Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…econnect - WsPublisher now connects as a client to RerunWebSocketServer (Python) instead of running its own axum server - Replaced axum + broadcast with tokio-tungstenite + mpsc - Drain queued commands on reconnect to avoid sending stale velocities - Changed --ws-port to --ws-url for full URL control - Moved WS_EVENTS.md to repo root with other docs
The Python server (websockets library) sends keepalive pings every 30s and expects a pong within 30s. The old code only wrote to the stream and never read, so tungstenite never got a chance to auto-reply with pong frames. This caused the server to close the connection every ~2 minutes. Split the stream into read/write halves and spawn a reader task that consumes incoming frames (triggering tungstenite's automatic pong replies). The write loop uses tokio::select! to also detect when the reader exits (server closed), triggering immediate reconnection instead of waiting for the next send to fail.
- Delete interaction/lcm.rs (LCM publisher no longer needed) - Simplify KeyboardHandler to take WsPublisher directly - Remove dual LCM/WS code paths in viewer.rs - Always connect via WebSocket (default ws://127.0.0.1:3030/ws)
Merges main's run_with_app_wrapper refactor while preserving WebSocket-only transport from this branch (no LCM dependency). - Use rerun's run_with_app_wrapper for cleaner CLI handling - WsPublisher now spawns its own tokio runtime thread (works without #[tokio::main]) - Inherits click-to-engage overlay and other UI improvements from main - Bump version to 0.30.0-alpha.6
- ruff F541: remove f-prefix from string without placeholders in test_keyboard_lcm.py - typos: serialised → serialized in ws.rs - lint.py: add blank lines before doc comments and methods in viewer.rs - lint.py: fix double space in ws.rs comment - cargo-shear: remove unused clap dependency
|
merged as a part of #22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
What