Split 2d and 3d tests to gain CI time.#626
Open
ThierryBerger wants to merge 4 commits intodimforge:masterfrom
Open
Split 2d and 3d tests to gain CI time.#626ThierryBerger wants to merge 4 commits intodimforge:masterfrom
ThierryBerger wants to merge 4 commits intodimforge:masterfrom
Conversation
ThierryBerger
added a commit
to ThierryBerger/bevy_rapier
that referenced
this pull request
Jan 15, 2025
ThierryBerger
commented
Jan 15, 2025
.github/workflows/main.yml
Outdated
Comment on lines
58
to
60
| - name: Unit Tests for bevy_rapier{{ matrix.dim }}d without default features | ||
| # cargo test by default also tests examples, which most need the debug render feature, so we pass `--lib` to only test the library | ||
| run: cargo test -p bevy_rapier{{ matrix.dim }}d --no-default-features --features dim{{ matrix.dim }} --lib |
Contributor
Author
There was a problem hiding this comment.
This is a new test, to check library against no default features (no async-collider and debug render)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI runs can take 20+ minutes currently: https://github.com/dimforge/bevy_rapier/actions/runs/13585069680/job/37978166712?pr=593
by providing 2 parallel jobs, we should be able to cut down time significantly.
ambiguity check should also probably be its own parallel check.