683 fix context swapping failing in non postupdate schedule#684
Open
AnthonyTornetta wants to merge 4 commits intodimforge:masterfrom
Open
Conversation
This reverts commit 343dd61.
The failure was caused by a run of sync_removals removing the just-added handles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The components added during a context changed were being immediately removed by the second run of
sync_removalsin PostUpdate. That PostUpdate call needs to happen for events to be captured properly, so I added some checks to make sure we should actually remove the entity from the simulation.@ThierryBerger lmk if you have any suggestions