Skip to content

should allow grounding with no movement counter to the up direction #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisJanssens wants to merge 5 commits into
base: master
Choose a base branch
from
+2 −1
Open

should allow grounding with no movement counter to the up direction #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9e3433
should allow grounding with no up movement
ChrisJanssens Apr 2, 2023
deda868
Merge branch 'master' into ChrisJanssens/master
ThierryBerger Jun 7, 2024
565174a
add changelog
ThierryBerger Jun 7, 2024
aace7f4
fix changelog wording
ThierryBerger Jun 7, 2024
20cb15c
fix changelog wording
ThierryBerger Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
to propagate it to the multibody).
- Remove an internal special-case for contact constraints on fast contacts. The doesn’t seem necessary with the substep
solver.
- Character controller's snap to ground can now trigger with a movement orthogonal to its up vector.

## v0.19.0 (05 May 2024)

Expand Down
2 changes: 1 addition & 1 deletion src/control/character_controller.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ impl KinematicCharacterController {
result: &mut EffectiveCharacterMovement,
) -> Option<(ColliderHandle, ShapeCastHit)> {
if let Some(snap_distance) = self.snap_to_ground {
if result.translation.dot(&self.up) < -1.0e-5 {
if result.translation.dot(&self.up) <= 0.0 {
let snap_distance = snap_distance.eval(dims.y);
let offset = self.offset.eval(dims.y);
if let Some((hit_handle, hit)) = queries.cast_shape(
Expand Down