Skip to content

viacuda: fix livelock caused by autopoll clobbering in-progress transactions #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dingusdev merged 1 commit into from
Feb 21, 2026
Merged

viacuda: fix livelock caused by autopoll clobbering in-progress transactions #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions devices/common/viacuda.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,13 +581,16 @@ void ViaCuda::autopoll_handler() {
this->do_post_keyboard_state_events = false;
}

// Don't start async packets while a transaction is in progress
// or Cuda already has unsent data (TREQ asserted).
// Events stay queued in ADB devices until the bus is idle.
if (!this->old_tip || !this->treq) {
return;
}

uint8_t poll_command = this->autopoll_enabled ? this->adb_bus_obj->poll() : 0;

if (poll_command) {
if (!this->old_tip || !this->treq) {
LOG_F(WARNING, "Cuda transaction probably in progress");
}

// prepare autopoll packet
response_header(CUDA_PKT_ADB, ADB_STAT_OK | ADB_STAT_AUTOPOLL);
this->out_buf[2] = poll_command; // put the proper ADB command
Expand Down
Loading