Reverted a change breaking the reverse flag in dwr.util.addOptions#6
Open
rogwes wants to merge 1 commit intodirectwebremoting:masterfrom
Open
Reverted a change breaking the reverse flag in dwr.util.addOptions#6rogwes wants to merge 1 commit intodirectwebremoting:masterfrom
rogwes wants to merge 1 commit intodirectwebremoting:masterfrom
Conversation
Contributor
|
Hey @rogwes, thanks for finding and reporting this! |
Author
|
Oh, I'm so sorry about the white space changes, that was my IDE setting that did that. I'll fix that. |
…lectid, map, reverse) call.
rogwes
force-pushed
the
util-js-addoptions-reverse-fix
branch
from
f51a86c to
7bf83a3
Compare
Author
|
Whitespaces fixed, just let me know when you need my action again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverted a change breaking the reverse flag in dwr.util.addOptions(selectid, map, reverse) call.
In commit 101a341 a change was introduced in dwr.util.addOptions to instead of checking if arg3 is falsy (null or false or something else that can be interpreted as false) it now checks if arg3 is null. The effect of this will is that calls like addOptions(selectid, map, false) will be interpreted the same as addOptions(selectid, map, true).thus ignoring the flag value.