This repository was archived by the owner on Apr 27, 2024. It is now read-only.
docs: various documentation improvements and fixes #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
approved these changes
Jul 26, 2020
vladfrangu
suggested changes
Jul 26, 2020
|
|
||
| /** | ||
| * When the last pinned message was pinned. | ||
| * When the last pinned message was pinned in the channel. |
Contributor
There was a problem hiding this comment.
Are we sure this isn't updated whenever we get a CHANNEL_PINS_UPDATE event?
Contributor
There was a problem hiding this comment.
Either I can't find it, or we don't even update it at all in the action...
https://github.com/dirigeants/core/blob/master/src/actions/channels/CHANNEL_PINS_UPDATE.ts
Contributor
Author
There was a problem hiding this comment.
Yep, you're right. Only place I see lastPinTimestamp set is in the constructor.
Contributor
There was a problem hiding this comment.
Can you submit a pull request for this? 😄
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various documentation errors and inconsistencies.