Preview Markdown in Embeds & Content Messages#93
Open
nikes wants to merge 1 commit intodiscohook:mainfrom
Open
Preview Markdown in Embeds & Content Messages#93nikes wants to merge 1 commit intodiscohook:mainfrom
nikes wants to merge 1 commit intodiscohook:mainfrom
Conversation
maddysrc
requested changes
Jun 24, 2023
Member
maddysrc
left a comment
maddysrc
left a comment
There was a problem hiding this comment.
The headers look too big and the list items aren't positioned well, needs some style adjustment first.
| transform?: (ast: SingleASTNode[]) => SingleASTNode[], | ||
| ) => { | ||
| const parse = parserFor(rules, { inline: true }) | ||
| const parse = parserFor(rules) |
Member
There was a problem hiding this comment.
Dropping inline here messes up a lot of assumptions that are present in how markdown rendering works and breaks a ton of other formatting in the website and this isn't the right way to go about it.
|
When can we expect the merge? |
Member
|
Not in its current state because it's broken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add: