fix: Add induced migration by django-parler 2.4#367
Open
fsbraun wants to merge 3 commits into
Open
Conversation
Contributor
Reviewer's GuideUpdates djangocms-alias to version 3.2.0 with a raised django-parler dependency, adds the new migration induced by django-parler 2.4 for CategoryTranslation constraints, adjusts the migration-checking test to run real migrations, and aligns test requirements accordingly. Entity relationship diagram for updated CategoryTranslation constraintserDiagram
CategoryTranslation {
string name
string language_code
int master_id
}
CategoryTranslation ||--o{ CategoryTranslation : master
%% Constraints
%% unique_together (name, language_code)
%% unique constraint (language_code, master) named djangocms_alias_category_translation_uniq_lang
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Switching
makemigrationsintest_for_missing_migrationsfromdry_run=Truetodry_run=Falsewill cause the test run to actually create migration files on disk; consider keeping it as a dry run and instead asserting on the command output or using Django’s--checkbehavior to detect missing migrations without side effects. - The new migration
0008_alter_categorytranslation_unique_together_and_moreis generated with a Django 6.1 dev snapshot header; you may want to regenerate it with one of the officially supported Django versions for this project to avoid unnecessary diffs and potential compatibility surprises.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Switching `makemigrations` in `test_for_missing_migrations` from `dry_run=True` to `dry_run=False` will cause the test run to actually create migration files on disk; consider keeping it as a dry run and instead asserting on the command output or using Django’s `--check` behavior to detect missing migrations without side effects.
- The new migration `0008_alter_categorytranslation_unique_together_and_more` is generated with a Django 6.1 dev snapshot header; you may want to regenerate it with one of the officially supported Django versions for this project to avoid unnecessary diffs and potential compatibility surprises.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
fsbraun
commented
May 16, 2026
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update alias app to support django-parler 2.4 and include the corresponding schema migration.
New Features:
Bug Fixes:
Enhancements:
Related resources
Checklist