migrate to pyproject.toml #67
Open
+102
−206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-r-a-v-i-n
force-pushed
the
migrate-to-pyproject-toml
branch
from
98d7794 to
6b82c5b
Compare
p-r-a-v-i-n
force-pushed
the
migrate-to-pyproject-toml
branch
from
6b82c5b to
89379ac
Compare
Member
Author
|
I have produce build on master and feature branch and have attached both the build below and screenshot which will show the diff in both the build. dclick-updated-build.tar.gz 
|
p-r-a-v-i-n
force-pushed
the
migrate-to-pyproject-toml
branch
from
89379ac to
7bd48d8
Compare
Member
Author
p-r-a-v-i-n
force-pushed
the
migrate-to-pyproject-toml
branch
from
7bd48d8 to
9f53ea1
Compare
Member
|
@p-r-a-v-i-n THANK YOU! This is something I've been wanting to dive into for a long while, but have been delayed. I'm not going to get a chance to review this in depth until January (getting married). If anyone else in @django-commons/django-click want to take a look, I wouldn't object! |
Member
|
I want to ping @ulgens in particular to recognize the great work done lately, and give an opportunity to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think we should move to pyproject.toml bcs maintaining pyproject.toml is easier for long run.
it also add simplicity and remove complexity.
i have shifted all the dependency to single file.
we no longer would need setup.py, requirements , flak8 files anymore.