fixed bug which caused bound forms to lose selected option

[io2]

in django forms.ModelForm types, the select > option value attribute is usually set to the primary key of the model object (typically an integer)

This commit converts field.value to string to ensure the if condition for adding selected to the <option> html is satisfied.

[smithdc1]

Hi @io2

Sorry for taking some time to get to this. There's a few things going on with this at the moment.

The first is that we should probably mirror the logic from checkboxes and radios. There are a few other edge cases we should look to capture. See this line here.

crispy-tailwind/crispy_tailwind/templates/tailwind/layout/checkboxselectmultiple.html

Line 8 in 3ad4c94

<input type="checkbox" class="{{ css_container.checkboxselectmultiple }}"{% if choice.0 in field.value or choice.0|stringformat:"s" in field.value or choice.0|stringformat:"s" == field.value|default_if_none:""|stringformat:"s" %} checked="checked"{% endif %} name="{{ field.html_name }}" id="id_{{ field.html_name }}_{{ forloop.counter }}" value="{{ choice.0|unlocalize }}" {{ field.field.widget.attrs|flatatt }}>

Secondly is that this can be improved using the new optgroups filter in django-crispy-forms which will simplify this logic here significantly. See django-crispy-forms/django-crispy-forms#1127

[io2]

@smithdc1 I'll take a look sometime and push an update.

[GitRon]

Hi @io2!

@smithdc1 I'll take a look sometime and push an update.

Any update on this topic? 🙂

Best
Ronny