Promote interactive browser login to the default for auth login#61
Merged
Conversation
Browser-based OAuth login was dark-launched in 0.9.1 behind `--web` and the `oauth_login` config gate. Now that the flow has shipped, make it the default on a terminal so authenticating no longer requires a flag. - `auth login` runs the OAuth browser flow by default on a TTY. - `--with-token` selects API-token auth (masked prompt on a TTY, reads stdin when piped or non-interactive). - `--web` is kept as a deprecated no-op for backward compatibility. - Remove the `oauth_login` config setting and `DNSIMPLE_OAUTH_LOGIN` env gate that guarded the dark launch.
Keep `--web` as a plainly accepted flag rather than a deprecated one: browser login is the default, so the flag has no effect, but it no longer emits a deprecation warning and stays visible in help. Remove the README authentication note that described the flow, and adjust the changelog wording accordingly.
Browser login is the default, so the inert --web flag served no purpose. Drop the flag and its variable; `dnsimple auth login --web` now errors as an unknown flag. Update the changelog to note the removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser-based OAuth login was dark-launched in 0.9.1, gated behind the
--webflag and theoauth_loginconfig setting. Now that the flow has shipped and proven out, this promotes it to the default so authenticating no longer requires a flag.🔍 QA
Scenario: Default browser login
dnsimple auth loginin a terminal. Confirm it opens the DNSimple authorization page in the browser and completes the login automatically once approved, with no flag and no token to paste.Scenario: Token login still available
dnsimple auth login --with-tokenin a terminal. Confirm it prompts to paste an API token (masked) and stores a context without launching the browser.echo "$TOKEN" | dnsimple auth login --with-token. Confirm it reads the token from stdin.echo "$TOKEN" | dnsimple auth login(no flag, non-interactive stdin). Confirm it still reads the token from stdin.Scenario: Deprecated
--webdnsimple auth login --web. Confirm it printsFlag --web has been deprecated, browser login is now the default; the flag is no longer neededand then proceeds with the default browser flow.dnsimple auth login --help. Confirm--with-tokenis listed and--webis hidden.📋 Deployment Pre/Post tasks
N/A
N/A