This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Conversation
b3e8d22 to
25bf749
Compare
docker/api/multierror wraps go-multierror from hashicorp with our default error formating
Contributor
Author
|
Build is passing |
Contributor
Author
|
There's a lot of wrapping here but it's needed... There is a PR opened that could help this but it's still not merged and it's from 2016, I commented on it, we'll see if hashicorp is willing in merging a PR that would make it possible to define a global formatting function. |
chris-crone
approved these changes
May 14, 2020
Contributor
chris-crone
left a comment
There was a problem hiding this comment.
LGTM
I really like this approach for the CLI errors. We should get @justincormack to review this for UX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker/api/multierror wraps go-multierror from hashicorp with our default error formatting.
Sample output: