commands: micro optimization for source date epoch#3770
Merged
jsternberg merged 1 commit intodocker:masterfrom Apr 3, 2026
Merged
commands: micro optimization for source date epoch#3770jsternberg merged 1 commit intodocker:masterfrom
jsternberg merged 1 commit intodocker:masterfrom
Conversation
crazy-max
previously approved these changes
Apr 2, 2026
Member
|
Ah, yes, I recalled I had a branch, but had to do some work in containerd first! (haven't looked yet at the code, but probably should be good 😅) |
jsternberg
force-pushed
the
containerd-source-date-epoch
branch
from
32712ed to
27e0e2d
Compare
crazy-max
requested changes
Apr 3, 2026
Avoids the call to `os.Getenv` when it is unnecessary because it would be overwritten anyway. Removes the comments about moving environment variable parsing to a method for use by library consumers. That method exists in containerd and this set of code doesn't actually perform any parsing since the parsing of this time is done within buildkit and not on the client. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
containerd-source-date-epoch
branch
from
27e0e2d to
d781c83
Compare
crazy-max
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids the call to
os.Getenvwhen it is unnecessary because it wouldbe overwritten anyway.
Removes the comments about moving environment variable parsing to a
method for use by library consumers. That method exists in containerd
and this set of code doesn't actually perform any parsing since the
parsing of this time is done within buildkit and not on the client.