Skip to content

fix(ci): run release safeguard test in unprivileged workflow - #77

Open
Sayt-0 wants to merge 1 commit into
mainfrom
fix/codeql-untrusted-checkout
Open

fix(ci): run release safeguard test in unprivileged workflow#77
Sayt-0 wants to merge 1 commit into
mainfrom
fix/codeql-untrusted-checkout

Conversation

@Sayt-0

@Sayt-0 Sayt-0 commented Aug 5, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to #76 that resolves CodeQL alert #204.

Before After
A privileged workflow_run job checked out github.event.workflow_run.head_sha and executed a PR-controlled shell script The shell test runs in the existing unprivileged pull_request/push test workflow
Future permission or runner changes could increase the blast radius The test remains isolated with contents: read and no secrets

Changes

  • remove the release caller-permissions test job from .github/workflows/test-e2e.yml
  • run tests/test-release-caller-permissions.sh after unit tests in .github/workflows/test.yml
  • preserve automatic PR coverage without executing PR-controlled code from workflow_run

Validation

  • actionlint -shellcheck=
  • bash tests/test-release-caller-permissions.sh (7 scenarios passed)
  • git diff --check

Move the PR-controlled shell test out of the workflow_run context and into the pull_request test workflow to resolve the CodeQL untrusted-checkout finding introduced by #76.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant