feat(runtime): add auto-stop for max iterations in non-interactive mode#2208
Open
tdabasinskas wants to merge 2 commits intodocker:mainfrom
Open
feat(runtime): add auto-stop for max iterations in non-interactive mode#2208tdabasinskas wants to merge 2 commits intodocker:mainfrom
tdabasinskas wants to merge 2 commits intodocker:mainfrom
Conversation
When max iterations are reached in non-interactive mode (e.g., MCP server), the runtime now automatically stops execution instead of blocking indefinitely waiting for user input. This prevents the system from hanging when `ToolsApproved` is true and provides a clear assistant message explaining why execution was stopped.
Contributor
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
…s approval - Add `NonInteractive` field to Session struct to explicitly mark sessions running without user interaction - Update runtime loop to use `NonInteractive` instead of `ToolsApproved` for auto-stopping logic - Set non-interactive mode in A2A adapter, evaluation framework, and MCP server - This separates the concept of approved tools from non-interactive execution context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When max iterations are reached in non-interactive mode (e.g., MCP server), the runtime now automatically stops execution instead of blocking indefinitely waiting for user input. This prevents the system from hanging when
ToolsApprovedis true and provides a clear assistant message explaining why execution was stopped.