Make TUI warnings persist until manually dismissed#2252
Open
dgageot wants to merge 1 commit intodocker:mainfrom
Open
Make TUI warnings persist until manually dismissed#2252dgageot wants to merge 1 commit intodocker:mainfrom
dgageot wants to merge 1 commit intodocker:mainfrom
Conversation
Warning and error notifications no longer auto-dismiss after 3 seconds. They display an [x] close button and remain visible until the user clicks on them. Success and info notifications continue to auto-dismiss. - Add persistent() and style() methods on notification Type - Add render() method on notificationItem to centralize rendering - Add HandleClick() on Manager for mouse-based dismissal - Clamp maxWidth to prevent underflow on very narrow terminals Fixes docker#2247 Assisted-By: docker-agent
rumpl
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning and error notifications no longer auto-dismiss after 3 seconds.
They display an
[x]close button and remain visible until the user clickson them. Success and info notifications continue to auto-dismiss.
persistent()andstyle()methods on notificationTyperender()method onnotificationItemto centralize renderingHandleClick()onManagerfor mouse-based dismissalmaxWidthto prevent underflow on very narrow terminalsFixes #2247