-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Replacing Yarn with npm in Docker Workshop #24012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- replace old Docker desktop screenshot with the new sidebar - Removed all references to Yarn in the explanation for Part 1 - Show new project directory structure for getting-started-repo
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
craig-osterhout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM.
Let me know if you want to add in the "what's next" changes to this PR, or merge it as-is.
Co-authored-by: Craig Osterhout <craig.osterhout@docker.com>
|
@craig-osterhout I have modified What's next page with:
|
|
Thanks for your work on these changes! 👍🏻 For the mounting examples, would it make sense to move from |
Description
Related issues or tickets
Reviews
This PR is heavily dependent upon docker/getting-started-app#98