socket: restore deprecated Transport.Dial (for now)#90
Draft
thaJeztah wants to merge 3 commits intodocker:mainfrom
Draft
socket: restore deprecated Transport.Dial (for now)#90thaJeztah wants to merge 3 commits intodocker:mainfrom
thaJeztah wants to merge 3 commits intodocker:mainfrom
Conversation
This reverts commit fcf9eb7. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
restore_legacy_code
branch
2 times, most recently
from
548eb07 to
a80c254
Compare
This restores the deprecated Transport.Dial, which were removed in commits: - 61039d0 (Replace deprecated Transport.Dial with Transport.DialContext) - fb772cf (Fix problems introduced by 61039d0) While we should still look at removing these, the moby code currently looks to be depending on their behavior. Removing them caused CI to fail, which blocked us from updating to the current version of this package. With those changes, Windows clients in CI were connecting with the wrong daemon, causing CI failures: Failed failed to get info from daemon: Error response from daemon: client version 1.41 is too new. Maximum supported API version is 1.40 exit status 1 FAIL github.com/docker/docker/integration/build 0.219s More details on moby/moby#41042 and moby/moby#41084 This patch restores the deprecated parts, but keeps the new variants as well, so that we can perform the migration in Moby when possible (after which they can be removed again) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
restore_legacy_code
branch
from
a80c254 to
e74611c
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
AkihiroSuda
reviewed
Aug 20, 2021
| return winio.DialPipeContext(ctx, addr) | ||
| // DialPipeContext() has been added to winio: | ||
| // https://github.com/Microsoft/go-winio/commit/5fdbdcc2ae1c7e1073157fa7cb34a15eab472e1d | ||
| // However, a new version of winio with this commit has not been released yet. |
Collaborator
There was a problem hiding this comment.
Seems included in go-winio v0.4.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #80
closes #80
relates to moby/moby#41042
relates to moby/moby#41084
This restores the deprecated Transport.Dial, which were removed in commits:
While we should still look at removing these, the moby code currently looks to
be depending on their behavior. Removing them caused CI to fail, which blocked
us from updating to the current version of this package:
With those changes, Windows clients in CI were connecting with the wrong daemon,
causing CI failures:
More details on moby/moby#41042 and moby/moby#41084
This patch restores the deprecated parts, but keeps the new variants as well,
so that we can perform the migration in Moby when possible (after which they
can be removed again)