fix: improve Dockerfiles and document Docker Desktop AI integration#21
Open
nomadicmehul wants to merge 2 commits intodocker:mainfrom
Open
fix: improve Dockerfiles and document Docker Desktop AI integration#21nomadicmehul wants to merge 2 commits intodocker:mainfrom
nomadicmehul wants to merge 2 commits intodocker:mainfrom
Conversation
- Add curl to Go and Python Dockerfiles for healthcheck support - Standardize healthcheck port configuration to use PORT env var - Remove duplicate HEALTHCHECK instruction in Go Dockerfile - Align EXPOSE directives with docker-compose configuration (port 8080) This ensures healthchecks work correctly in containerized environments and maintains consistency across all three language implementations.
- Add documentation for LLAMA_URL and LLAMA_MODEL environment variables - Clarify Docker Desktop AI model integration as recommended approach - Document legacy LLM_BASE_URL and LLM_MODEL_NAME as fallback options - Explain port configuration differences between local and Docker usage - Update all service READMEs (Go, Python, Rust) for consistency This helps users understand how to use the apps with Docker Desktop's integrated AI models feature while maintaining backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the Dockerfiles and documentation across all three service implementations (Go, Python, Rust).
Changes
Dockerfile Improvements
curlto Go and Python Dockerfiles for healthcheck supportDocumentation Updates
Benefits