Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR refactors the container’s QEMU start/shutdown flow to centralize PID handling and improve shutdown behavior, while also bumping the QEMU base image version.
Changes:
- Standardize PID file variables for Samba/WSDD components and reuse them when starting/stopping services.
- Rework QEMU startup output handling in
entry.shand update shutdown/trap logic inpower.sh(newSHUTDOWN/TIMEOUTcontrols). - Update the Docker base layer to
qemux/qemu:7.32.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/samba.sh |
Introduces PID file variables and reuses them for cleanup and wsddn startup. |
src/power.sh |
Refactors graceful shutdown/trap handling and consolidates process cleanup. |
src/entry.sh |
Changes QEMU launch to a FIFO-based output path when SHUTDOWN is enabled. |
Dockerfile |
Bumps QEMU base image version from 7.31 to 7.32. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [ -n "${QEMU_TIMEOUT:-}" ] && TIMEOUT="$QEMU_TIMEOUT" | ||
|
|
||
| _trap _graceful_shutdown SIGTERM SIGHUP SIGINT SIGABRT SIGQUIT | ||
| _trap graceful_shutdown SIGTERM SIGHUP SIGABRT SIGQUIT |
kroese
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.