Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts shutdown-related log messages in src/power.sh to make it explicit that the received value is a signal (e.g., SIGTERM) and improve readability of the output during graceful shutdown handling.
Changes:
- Update
graceful_shutdown()log strings to include the word “signal” when reporting what was received. - Slightly clarify the shutdown flow messaging when already shutting down vs. initiating ACPI shutdown.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| if [ -f "$QEMU_END" ]; then | ||
| echo && info "Received $1 while already shutting down..." | ||
| echo && info "Received $1 signal while already shutting down..." |
| set +e | ||
| touch "$QEMU_END" | ||
| echo && info "Received $1, sending ACPI shutdown signal..." | ||
| echo && info "Received $1 signal, sending ACPI shutdown signal..." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.