refactor(enricher): use docling-core keywords meta field and remove keyphrases style#38
Merged
Conversation
Signed-off-by: Cesar Berrospi Ramis <ceb@zurich.ibm.com>
Leverage the new 'keywords' meta field in DoclingDocument to populate keywords from 'generate_keywords' in the enricher agent. Drop the 'keyphrases' style in 'generate_summary' since now keywords are supported in DoclingDocument meta field. Signed-off-by: Cesar Berrospi Ramis <ceb@zurich.ibm.com>
Contributor
|
✅ DCO Check Passed Thanks @ceberam, all your commits are properly signed off. 🎉 |
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Changes
styleparameter from_generate_summary(),_summarize_pages(), and_generate_document_level_summary()methodsChanges
Keywords Integration with docling-core
DoclingEnrichingAgentare now stored inBaseMeta.keywords(usingKeywordsMetaField) instead of the customdocling_agent__keywordsfieldImproved Keyword Generation
Summary Generation Simplification
keywordsmeta field_generate_summary()now only generates sentence-based summariesstyleparameter from all calling methodsTests
test_generate_keywords(): Tests keyword generation with semicolon formattest_find_search_keywords(): Tests full keyword extraction workflowstyleparameter in summary testsMotivation
This refactoring aligns keyword handling with how summaries and entities are managed in docling-core, providing a consistent metadata structure. The removal of the "keyphrases" style from summaries eliminates redundancy now that proper keyword support exists.
Testing
All 17 tests pass successfully ✅