feat(rag): expose reasoning trace via public run_with_trace()#39
Open
pjmalandrino wants to merge 1 commit into
Open
feat(rag): expose reasoning trace via public run_with_trace()#39pjmalandrino wants to merge 1 commit into
pjmalandrino wants to merge 1 commit into
Conversation
Add RAGTrace model (query, per_document, final_answer) and a public run_with_trace() method on DoclingRAGAgent returning the full per-iteration trace that was previously discarded inside run(). run() becomes a thin wrapper around run_with_trace(): single source of truth for the loop, no behavior change for existing callers. RAGTrace, RAGResult and RAGIteration are re-exported at package level so downstream consumers can type-hint against the trace. Closes docling-project#26 Signed-off-by: Pier-Jean Malandrino <pierjean.malandrino@scub.net>
Contributor
|
✅ DCO Check Passed Thanks @pjmalandrino, all your commits are properly signed off. 🎉 |
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesWaiting for
This rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Open
12 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RAGTrace model (query, per_document, final_answer) and a public run_with_trace() method on DoclingRAGAgent returning the full per-iteration trace that was previously discarded inside run().
run() becomes a thin wrapper around run_with_trace(): single source of truth for the loop, no behavior change for existing callers.
RAGTrace, RAGResult and RAGIteration are re-exported at package level so downstream consumers can type-hint against the trace.
Closes #26