refactor: Extract reusable framework from tests#2
Open
nitinahuja89 wants to merge 1 commit intodocumentdb:mainfrom
Open
refactor: Extract reusable framework from tests#2nitinahuja89 wants to merge 1 commit intodocumentdb:mainfrom
nitinahuja89 wants to merge 1 commit intodocumentdb:mainfrom
Conversation
Collaborator
nitinahuja89
commented
Mar 10, 2026
nitinahuja89
commented
- Create framework/ package with assertions and fixtures modules
- Move tests/common/assertions.py to framework/assertions.py
- Extract fixture utilities from conftest.py to framework/fixtures.py
- Update all test files to import from framework
- Update conftest.py to use framework.fixtures
- Remove tests/common/ directory
- Create framework/ package with assertions and fixtures modules - Move tests/common/assertions.py to framework/assertions.py - Extract fixture utilities from conftest.py to framework/fixtures.py - Update all test files to import from framework - Update conftest.py to use framework.fixtures - Remove tests/common/ directory Signed-off-by: Nitin Ahuja <nitinahuja.89@gmail.com>
nitinahuja89
force-pushed
the
test-organization
branch
from
58f6aea to
cf0492f
Compare
seoc01
reviewed
Mar 10, 2026
seoc01
left a comment
seoc01
left a comment
There was a problem hiding this comment.
Can you add a top level "documentdb_tests" folder, so that an other test suite using the framework an reference it with "documentdb_tests.framework" to avoid the generic import of just "framework"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.