fix: preserve leading underscores in ToPascalCase to avoid field collisions

[hanneshayashi]

Problem

Properties like _id and id both normalized to Id in PascalCase, causing Go struct field redeclaration errors:

type CloudDiagramSnapshotModel struct {
    Id types.String `tfsdk:"_id"`   // ← redeclared
    Id types.String `tfsdk:"id"`    // ← original
}

This is common in MongoDB-backed APIs where _id is the document ID.

Fix

ToPascalCase now prepends Underscore when the identifier starts with _:

• _id → UnderscoreId
• id → Id (unchanged)

Only the Go struct field name changes — the tfsdk tag preserves the original attribute name.

Result

type CloudDiagramSnapshotModel struct {
    UnderscoreId types.String `tfsdk:"_id"`
    Id           types.String `tfsdk:"id"`
}

Testing

• All framework tests pass (go test ./...)
• Provider make generate + go build ./... succeed

[Copilot]

Pull request overview

This PR updates the schema identifier casing logic so Terraform attribute names that begin with _ do not collide with their non-underscored equivalents when generating Go struct field names (e.g., _id vs id).

Changes:

• Update FrameworkIdentifier.ToPascalCase() to prepend Underscore for identifiers starting with _.
• Update identifier casing tests to reflect the new leading-underscore behavior across camel/pascal conversions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
internal/schema/framework_identifier.go	Adjusts PascalCase generation to avoid _x/x Go field name collisions by preserving leading underscores via a prefix.
internal/schema/framework_identifier_test.go	Updates expected casing outputs for identifiers with leading underscores.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.