100% TMario::actnMain #70
Merged
+134
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrkol
requested changes
Jan 30, 2026
include/Player/MarioMain.hpp
Outdated
| void changeHand(int); | ||
| void isAnimeLoopOrStop(); | ||
| void isLast1AnimeFrame(); | ||
| s32 isLast1AnimeFrame(); |
Collaborator
There was a problem hiding this comment.
BOOL instead of s32 if bool doesn't match
Contributor
Author
There was a problem hiding this comment.
Fixed both of these :)
include/Player/MarioMain.hpp
Outdated
| void isSpeedZero(); | ||
| void canBendBody(); | ||
| void considerRotateJumpStart(); | ||
| s32 considerRotateJumpStart(); |
Collaborator
There was a problem hiding this comment.
Same here, if it's a bool-ish return and bool doesn't match -- use BOOL
Report for GMSJ01 (dd80eda - c30a535)📈 Matched code: 25.60% (+0.02%, +600 bytes) ✅ 1 new match
📈 1 improvement in unmatched functions
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting my new years resolution of not making huge PRs :)
Edit:
Maybe for next year it should be to proof read my code before making a PR...