Added android support.#257
Conversation
|
@AzulEterno Thanks a lot for your contribution! Before going into details about the PR, I think one thing worth checking: One specific question on the clipboard piece: does pressing the copy key in the current shipping binary on Termux actually fail for you (error, crash, no-op)? arboard needs X11/Wayland/Win32 and the |
|
Actually, this is patch serves different purpose for generic linux android musl version. Musl version usually runs within provided musl lib c by termux (Or other alpine proot env), Provided patch version is built against android ndk toolkit, which uses native android bionic libc bindings. So it can run natively even in Android system opened shell without musl support. Althrough it's kind of limited user scope (Only tested in root priviledge since it might use bpf feature and need Android sdk >= 28 for some feature support.) So it's more sort of "Native" android support. I think it has it's merits but final decision it's up to you. |
|
Regarding the clipboard issue, I would further investigate it. I remembered it as failing because some features were missing in native android glibc. I will report when I have more intel on this. |
|
Regarding android support that sounds good to me. I'll go through your PR and I think a couple things we might need to address but if this helps some users on android I think it is a good contribution. |
Add advanced android user support. Only tested on root user execution.