Conversation
There was a problem hiding this comment.
Pull request overview
Enhances the OAuth2 callback handler in AuthenticationLoading to correctly handle backend responses that require MFA, preventing invalid/undefined tokens from being stored and guiding the user through MFA verification before completing login.
Changes:
- Adds MFA state +
MFAVerificationModalwiring to the OAuth2 callback flow. - Switches token persistence from direct
localStoragewrites to centralizedsaveTokens. - Improves OAuth2 callback error handling and validates presence of tokens / MFA session token.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+208
to
+211
| onError={() => { | ||
| setMessage('Authentication failed') | ||
| setSubMessage('Two-factor authentication failed. Please try again') | ||
| }} |
Comment on lines
91
to
93
| const redirectURI = Capacitor.isNativePlatform() | ||
| ? 'donetick://auth/oauth2' | ||
| : `${window.location.origin}/auth/oauth2` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances the OAuth2 authentication flow in
Authenticating.jsxby adding support for multi-factor authentication (MFA).fix #108