Skip to content

Feature/language support#82

Open
tamtam1111 wants to merge 6 commits into
donetick:mainfrom
tamtam1111:feature/language-support
Open

Feature/language support#82
tamtam1111 wants to merge 6 commits into
donetick:mainfrom
tamtam1111:feature/language-support

Conversation

@tamtam1111

Copy link
Copy Markdown

Hey,
I added language support.
German was key for me and looks good enough for me but I also added Spanish and Portuguese for testing(AI Translated). Not sure if they are completely correct.
Due to the hardcoded texts nearly all files have been touched.
Nice work by the way!

@gitguardian

gitguardian Bot commented Apr 4, 2026

Copy link
Copy Markdown

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@hoborm

hoborm commented Apr 4, 2026

Copy link
Copy Markdown
Collaborator

@meauxt has already done some work for the internationalization, but nevertheless it's very useful to have your PR too.
I'll compare and review both and hopefully it will be implemented in the near future with it's release!
Thank you @tamtam1111

@meauxt

meauxt commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Apologies for the delayed response, and thank you for the PR! For future reference, if you're planning a significant change, let's communicate first to ensure we aren't duplicating work.
I recently merged an older localization PR that overlaps with this one. Since your PR includes additional changes, could you please review the current codebase and rebase/adjust your branch accordingly?
If you'd prefer to discuss this in real-time, feel free to reach out on Discord

Again, thank you for the contribution!

@tamtam1111 tamtam1111 force-pushed the feature/language-support branch from 6f99ab9 to 7f09c05 Compare April 13, 2026 19:50
@tamtam1111

Copy link
Copy Markdown
Author

Hey, I did some merging and updating. I hope I haven’t caused more problems than I fixed. My GitHub knowledge is limited.

@hoborm hoborm self-requested a review April 21, 2026 21:07
@hoborm hoborm self-assigned this Apr 21, 2026
@hoborm

hoborm commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

Hey, I did some merging and updating. I hope I haven’t caused more problems than I fixed. My GitHub knowledge is limited.

Really appreciate the work, at a quick glance it looks good, however we'd like to omit the AI translated files. Can you please remove them from the PR? We are hoping to rely on community contributions on translating the project.

@tamtam1111

tamtam1111 commented Apr 23, 2026

Copy link
Copy Markdown
Author

removed it although there weren't any translations. It should use the English fallback. Kept the German translation.

@hoborm

hoborm commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

removed it although there weren't any translations. It should use the English fallback. Kept the German translation.

once again, thank you for your work! I'll look into reviewing it as soon as I have time and we'll hopefully implement it into the beta soon.

Comment thread src/utils/Chores.jsx Outdated
Comment thread src/views/Authorization/LoginView.jsx
Comment thread src/views/ChoreEdit/ChoreEdit.jsx
Comment thread src/views/ChoreEdit/RepeatSection.jsx
Comment thread src/views/ChoreEdit/RepeatSection.jsx
Comment thread src/views/ChoreEdit/RepeatSection.jsx
Comment thread src/views/ChoreEdit/ThingTriggerSection.jsx Outdated
Comment thread src/views/Chores/hooks/useChoreActions.js Outdated
@tamtam1111 tamtam1111 force-pushed the feature/language-support branch from 413089b to 051340d Compare June 4, 2026 18:20
@tamtam1111

Copy link
Copy Markdown
Author

Hey, sorry for the delay. I was short on time. I hope I addressed all of your review comments. I am still getting used to GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants