Skip to content

Bugfix/rework api input validation frontend#84

Open
hoborm wants to merge 6 commits into
donetick:mainfrom
hoborm:bugfix/rework-api-input-validation-frontend
Open

Bugfix/rework api input validation frontend#84
hoborm wants to merge 6 commits into
donetick:mainfrom
hoborm:bugfix/rework-api-input-validation-frontend

Conversation

@hoborm

@hoborm hoborm commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the frontend chore action APIs to align with the backend's updated input-validation expectations, mainly by changing how completion/rejection payloads are passed through the fetch layer.

Changes:

  • Reworked MarkChoreComplete to build a JSON request body from discrete completedBy, completedDate, and notes parameters instead of mixing query params and body data.
  • Updated chore action call sites to use the new completion/rejection signatures.
  • Adjusted the React Query mutation wrapper to expose the new completion argument shape.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/views/ChoresOverview.jsx Updates completion-from-overview flow to call the new MarkChoreComplete signature.
src/views/Chores/hooks/useChoreActions.js Reworks several chore action handlers and bulk actions to use the new completion/rejection API shape.
src/views/ChoreEdit/ChoreView.jsx Updates single-chore completion and rejection actions to the new fetch helper signature.
src/utils/Fetcher.jsx Refactors MarkChoreComplete and RejectChore request construction.
src/queries/ChoreQueries.jsx Aligns the React Query mutation wrapper with the new MarkChoreComplete parameters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/views/Chores/hooks/useChoreActions.js Outdated
Comment thread src/views/Chores/hooks/useChoreActions.js Outdated
Comment thread src/views/Chores/hooks/useChoreActions.js Outdated
Comment thread src/views/Chores/hooks/useChoreActions.js Outdated
Comment thread src/views/ChoreEdit/ChoreView.jsx Outdated
Comment thread src/views/ChoresOverview.jsx Outdated
hoborm and others added 3 commits May 12, 2026 18:16
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@hoborm

hoborm commented May 12, 2026

Copy link
Copy Markdown
Collaborator Author

@meauxt please re-run copilot if you think it's needed.

@hoborm hoborm requested a review from meauxt May 12, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants