Bugfix/rework api input validation frontend#84
Open
hoborm wants to merge 6 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the frontend chore action APIs to align with the backend's updated input-validation expectations, mainly by changing how completion/rejection payloads are passed through the fetch layer.
Changes:
- Reworked
MarkChoreCompleteto build a JSON request body from discretecompletedBy,completedDate, andnotesparameters instead of mixing query params and body data. - Updated chore action call sites to use the new completion/rejection signatures.
- Adjusted the React Query mutation wrapper to expose the new completion argument shape.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/views/ChoresOverview.jsx |
Updates completion-from-overview flow to call the new MarkChoreComplete signature. |
src/views/Chores/hooks/useChoreActions.js |
Reworks several chore action handlers and bulk actions to use the new completion/rejection API shape. |
src/views/ChoreEdit/ChoreView.jsx |
Updates single-chore completion and rejection actions to the new fetch helper signature. |
src/utils/Fetcher.jsx |
Refactors MarkChoreComplete and RejectChore request construction. |
src/queries/ChoreQueries.jsx |
Aligns the React Query mutation wrapper with the new MarkChoreComplete parameters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
@meauxt please re-run copilot if you think it's needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.