Skip to content

CI update#8

Merged
donghoonpark merged 3 commits into
masterfrom
feature.dev
Dec 7, 2025
Merged

CI update#8
donghoonpark merged 3 commits into
masterfrom
feature.dev

Conversation

@donghoonpark

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 63 to +66
env:
QT_API: ${{ matrix.qt-binding }}
run: |
if ( "$RUNNER_OS" == "Linux" ); then
xvfb-run -a uv run --no-sync pytest
else
uv run --no-sync pytest
fi
uv run --no-sync pytest

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep Linux pytest under a virtual display

Linux matrix jobs now invoke uv run --no-sync pytest directly without the previous xvfb-run wrapper. The test suite spins up Qt widgets via pytest-qt (e.g., qtbot.addWidget in tests/test_color_range_widget.py), and GitHub’s ubuntu-latest runners are headless with no DISPLAY, so Qt will abort with “Could not connect to display” and all Linux jobs will fail. Reintroduce xvfb-run (or set QT_QPA_PLATFORM=offscreen) when runner.os == 'Linux' to preserve the virtual display used before.

Useful? React with 👍 / 👎.

@donghoonpark donghoonpark merged commit c617275 into master Dec 7, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant