Refactor tests and add more tests

[auouymous]

No description provided.

[donniebreve]

Please provide reasoning for this refactoring.

[auouymous]

It avoids mistakes like #76.

It tracks the total number of tests and number of failed tests, returning a non-zero status code upon failure. The tests could now be run in the test.yml workflow.

It condenses the duplicate code of every test making them easier to write and read. The named keys also aid in readability, replacing the comment of many tests.

The second commit adds tests for features that were missing them. There are also sample tests at the bottom which could be implemented now that it is easier to write them, and the new syntax closely resembles that of the samples.

[donniebreve]

It avoids mistakes like #76.

I don't think it does. Mistakes will happen, regardless of how crafty your code is.

It tracks the total number of tests and number of failed tests, returning a non-zero status code upon failure. The tests could now be run in the test.yml workflow.

This is a useful addition which wouldn't require adding string representations of the key codes. The tests do run in test.yml.

It condenses the duplicate code of every test making them easier to write and read. The named keys also aid in readability, replacing the comment of many tests.

This I can agree with, although I am against the implementation. I would prefer using the KEY_ identifiers instead of arbitrary names.

The second commit adds tests for features that were missing them. There are also sample tests at the bottom which could be implemented now that it is easier to write them, and the new syntax closely resembles that of the samples.

Additions like TYPE("hyper down, seq tap, hyper up", EXPECT, "seq1 down, seq2 down, seq1 up, seq2 up"); are really no more readable than the previous implementation. The expected output requires understanding more than the words used here.