Open
Conversation
Author
|
ping @donovanhide |
Author
|
@donovanhide Please have a look at the PR. |
Owner
|
This is too big a change to accept without added unit tests that prove current behaviour is not subtly altered. |
Author
|
It only changes the implementation of all the APIs not the API itself. So the existing test cases are exactly for that.
…Sent from my iPhone
On Apr 12, 2018, at 18:34, Donovan Hide ***@***.***> wrote:
This is too big a change to accept without added unit tests that prove current behaviour is not subtly altered.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there are several issues with the library.
Closeis not thread safe. theisStreamClosedcannot protect a gorouting sending to a panic panel. ref: Check if a stream is closed just before writing to the stream channels #33Socket leaks. If the server responds with a 404, the
resp.Body.Closeis not called.The changes should not affect any existing users.