Skip to content

Conversation

@nathenharvey
Copy link
Collaborator

@nathenharvey nathenharvey commented Dec 30, 2025

Migrate content-specific assets from global static directories to their respective research page bundles (2019, 2023, 2024) and remove unused files.

Key changes:

  • Move 2019 Big Friendly Diagram assets to content/research/2019/
  • Move 2023 Infographic and thumbnail to content/research/2023/
  • Move 2024 survey graphics to content/research/2024/
  • Update content references to use local bundle paths
  • Delete unused assets from static/img/features, misc, and quickcheck
  • Add explanation README for sodr_thumbnails

Configuration:

  • Register 301 redirects for all moved assets in firebase.json
  • Add corresponding regression tests in test/redirects/redirects.csv

This fixes #66

Preview URLs:

@github-actions
Copy link

github-actions bot commented Dec 30, 2025

Visit the preview URL for this PR (updated for commit 40024ff):

https://doradotdev--pr1267-drafts-on-tgv3v24d.web.app

(expires Thu, 29 Jan 2026 13:18:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7ad2b3cf9cceb558b493931176f998ae46924361

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively reorganizes content-specific assets into their respective research page bundles, which is a great step for improving maintainability. The changes are well-implemented, including the addition of 301 redirects for moved assets and corresponding regression tests. The cleanup of unused static files is also a welcome improvement. I have one suggestion to improve accessibility by adding an alt tag to an image. Otherwise, this is a solid pull request.

Why did the coffee file a police report? It got mugged!

Migrate content-specific assets from global static directories to their respective research page bundles (2019, 2023, 2024) and remove unused files.

Key changes:
- Move 2019 Big Friendly Diagram assets to `content/research/2019/`
- Move 2023 Infographic and thumbnail to `content/research/2023/`
- Move 2024 survey graphics to `content/research/2024/`
- Update content references to use local bundle paths
- Delete unused assets from `static/img/features`, `misc`, and `quickcheck`
- Add explanation README for `sodr_thumbnails`

Configuration:
- Register 301 redirects for all moved assets in `firebase.json`
- Add corresponding regression tests in `test/redirects/redirects.csv`

This fixes #66
@nathenharvey nathenharvey marked this pull request as ready for review December 30, 2025 13:53
Copy link
Collaborator

@sapientcoffee sapientcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sapientcoffee sapientcoffee merged commit 82fc626 into main Jan 2, 2026
7 checks passed
@sapientcoffee sapientcoffee deleted the push-lowmrnwnwvro branch January 2, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move content-specific assets into bundle folders

3 participants