Skip to content

Conversation

@nathenharvey
Copy link
Collaborator

Updates the preview workflow to include a new job for testing redirects against the deployed preview URL.

Changes:

  • Adds a test_redirects job that runs npx mocha test-redirects.js using the preview_url from the build_drafts_on job.
  • Configures the redirect tests to run on Node.js 24.x in the ./test/redirects directory.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Visit the preview URL for this PR (updated for commit c958eb3):

https://doradotdev--pr1271-drafts-off-efhso053.web.app

(expires Wed, 04 Feb 2026 20:09:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7ad2b3cf9cceb558b493931176f998ae46924361

@nathenharvey nathenharvey force-pushed the push-lxplmlvyxyow branch 4 times, most recently from 63aa784 to 31ca504 Compare January 5, 2026 17:09
Updates the preview workflow to include a new job for testing redirects against the deployed preview URL.

Changes:
- Adds a `test_redirects` job that runs `npx mocha test-redirects.js` using the `preview_url` from the `build_drafts_on` job.
- Configures the redirect tests to run on Node.js 24.x in the `./test/redirects` directory.
@nathenharvey
Copy link
Collaborator Author

I've added test_redirect as a required status checks to pass before merging, too.

@nathenharvey nathenharvey marked this pull request as ready for review January 5, 2026 17:13
Copy link
Collaborator

@davidstanke davidstanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidstanke davidstanke merged commit 95c541a into main Jan 5, 2026
8 checks passed
@davidstanke davidstanke deleted the push-lxplmlvyxyow branch January 5, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants