-
Notifications
You must be signed in to change notification settings - Fork 39
feat: Add "Insights" section to top-level navigation and migrate content #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Visit the preview URL for this PR (updated for commit feeae28): https://doradotdev--pr1272-drafts-off-35gnyjd7.web.app (expires Thu, 05 Feb 2026 23:21:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7ad2b3cf9cceb558b493931176f998ae46924361 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully elevates DORA's research insights into a dedicated "Insights" section in the top-level navigation, which is a great move for content discoverability. The changes are comprehensive, covering navigation updates, content migration, new UI elements, and updated tests. The code is clean and the migration of content from research/shared and experimental to the new insights/ directory is well-executed. My review includes a couple of suggestions to improve the consistency of the active state highlighting for the new navigation item in hugo/themes/dora-2025/layouts/partials/header.html. Why did the coffee file a police report? It got mugged!
This change elevates DORA's research insights by establishing a dedicated "Insights" section in the top-level navigation, making this high-value content more discoverable and accessible to users. It also allows us to create "Insights" that aren't stricly research-related. For example, we may decide to add an "insight" that is DORA 2025 year in review. Key changes: - **Navigation**: Added "Insights" to the main menu (desktop and mobile) between "Guides" and "Quick Check". - **Content Structure**: Migrated relevant articles and shared bundles from `research/shared` and `experimental` to a new `insights/` directory structure. This aligns the filesystem with the public URL structure. - **UI/Visuals**: Implemented a distinct banner for the Insights section using `dora-vermillion` and the DORA perspective icon. Updated header logic to ensure the banner appears on all insights pages, including tags. - **Cleanup**: Updated all `render_headless_bundle` references and fixed image links to reflect the new paths. Removed obsolete experimental content. - **Testing**: Updated Playwright navigation tests to verify the presence of the new link. Fixes #1187
bcbb8c5 to
fd9781a
Compare
davidstanke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e13b62c to
87875a6
Compare
Updates the visual hierarchy of the single insight page by tightening the metadata block (byline, date, tags) to create a more cohesive header. Adjusts vertical rhythm throughout to reduce visual clutter.
87875a6 to
feeae28
Compare
This change elevates DORA's research insights by establishing a dedicated "Insights" section in the top-level navigation, making this high-value content more discoverable and accessible to users. It also allows us to create "Insights" that aren't stricly research-related. For example, we may decide to add an "insight" that is DORA 2025 year in review.
Key changes:
research/sharedandexperimentalto a newinsights/directory structure. This aligns the filesystem with the public URL structure.dora-vermillionand the DORA perspective icon. Updated header logic to ensure the banner appears on all insights pages, including tags.render_headless_bundlereferences and fixed image links to reflect the new paths. Removed obsolete experimental content.Preview URLs:
<p>)<h2>)Fixes #1187