-
Notifications
You must be signed in to change notification settings - Fork 481
issue 23628 admin site api #33973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wezell
wants to merge
21
commits into
main
Choose a base branch
from
issue-23628-management-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
issue 23628 admin site api #33973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #23628
This PR creates the idea of a canonical
ADMIN_SITE_URLwhich is the URL that is used to manage the site. If that config variable is set then any admin URLs, e.g./dotAdminwill not be available on any other domain that points to the site. It will also automatically set thex-robots-tag: noindex, nofollowon any site that is marked as admin as well.The
ADMIN_SITE_URLcan only be set as a ENV or system config variable.Lots of config switches:
ADMIN_SITE_ENABLED: boolean. This functionality is disabled by default and can be enabled by setting this variable to trueADMIN_SITE_URL: String. the main canonical url for all admin requests - this is protocol :// domain (:optional port), e.g.https://admin.dotcms.comorhttps://my.supersite.com:8443.ADMIN_SITE_REQUESTS_FORCE_SECURE: boolean. defaults to false, can be set to force https (or 8082) for all admin requestsADMIN_SITE_REQUEST_HEADERS: comma separate list. response headers to add to request to admin sites. Defaults tox-robots-tag: noindex, nofollowADMIN_SITE_REQUEST_DOMAINS: comma separate list. domains that should be considered as "admin only" domains. These values are automatically added to this list:ADMIN_SITE_REQUEST_DOMAINS_EXCLUDE: comma separate list. remove these domains from the list of admin domainsADMIN_SITE_REQUEST_URIS: comma separate list. uris that should be considered as "admin only" uris. These values are already added to this list:ADMIN_SITE_REQUEST_URIS_EXCLUDE: comma separate list. Remove these URIS as admin URIs