fix: add empty object in place of variables for more consistent keys

[rliljest]

Description

Addresses potential issues stemming from mismatched generated keys.

Related #866

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

NOTE: Does have a fairly minor breaking change in case clients were hard-coding keys (not using generated helpers) and specifying "exact" react-query key matching

How Has This Been Tested?

Automated tests have been updated to accommodate this change

Test Environment:

• OS: macOS
• @graphql-codegen/typescript-react-query: 6.1.0

Checklist:

• I have followed the
  CONTRIBUTING doc and the
  style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[changeset-bot]

🦋 Changeset detected

Latest commit: 761b305

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@graphql-codegen/typescript-react-query	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[rliljest]

Is there anything that I'm missing to get this PR approved and merged? The issue that this resolves persists

need someone else to give feedback

[saihaj]

@TkDodo thoughts?

[TkDodo]

looking at the linked issue, if you want to treat

useDummyQuery()

and

useDummyQuery({})

the same, I guess this change is what you want. A real-life example would be helpful though. Like, why isn't the argument for useDummyQuery required so that there is only one syntax to achieve the same thing?

This may be a breaking change if users were invalidating based on exact query key matches without using the .getKey helper, although that seems unlikely

agree with that sentiment, too.

[TkDodo]

why not default variables to {} to avoid the extra check:

variables?: CurrentUserForProfileQueryVariables = {},

return useQuery(['CurrentUserForProfile', variables])

[rliljest]

Updated and rebased changes to follow your suggestion

[rliljest]

... why isn't the argument for useDummyQuery required so that there is only one syntax to achieve the same thing?

That would be another valid solution to the underlying issue. The main reason why I took the approach I did in this MR was to avoid breaking changes by forcing users to supply an empty object when they did not previously.

Another thing to consider is that currently in the codegen there is no differentiation between a query that takes no arguments vs. a query that takes no required arguments. So that approach would require users to provide an empty object on queries that do not take any arguments at all, which seems like an unnecessary breaking change

[rliljest]

@saihaj Anything outstanding that I can explain/address to get this approved and merged?