Skip to content

chore: Move dotMemory/dotTrace tests to IntegrationTests.ManualRunning project #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timcassell merged 1 commit into from
Feb 27, 2026
+7 −9
Merged

chore: Move dotMemory/dotTrace tests to IntegrationTests.ManualRunning project #3031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...tNet.IntegrationTests.ManualRunning/BenchmarkDotNet.IntegrationTests.ManualRunning.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
<ItemGroup>
<ProjectReference Include="..\..\src\BenchmarkDotNet\BenchmarkDotNet.csproj" />
<ProjectReference Include="..\..\src\BenchmarkDotNet.Diagnostics.Windows\BenchmarkDotNet.Diagnostics.Windows.csproj" />
<ProjectReference Include="..\..\src\BenchmarkDotNet.Diagnostics.dotTrace\BenchmarkDotNet.Diagnostics.dotTrace.csproj" />
<ProjectReference Include="..\..\src\BenchmarkDotNet.Diagnostics.dotMemory\BenchmarkDotNet.Diagnostics.dotMemory.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
Expand Down
5 changes: 2 additions & 3 deletions ...DotNet.IntegrationTests/DotMemoryTests.cs → ...tionTests.ManualRunning/DotMemoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
using Xunit;
using Xunit.Abstractions;

namespace BenchmarkDotNet.IntegrationTests
namespace BenchmarkDotNet.IntegrationTests.ManualRunning
{
public class DotMemoryTests : BenchmarkTestExecutor
{
Expand All @@ -30,8 +30,7 @@ public void DotMemorySmokeTest()
var config = new ManualConfig().AddJob(
[
Job.Dry.WithId("ExternalProcess"),
// TODO: Add InProcessEmitToolchain job when flaky test issue is resolved https://github.com/dotnet/BenchmarkDotNet/issues/2950
//Job.Dry.WithToolchain(InProcessEmitToolchain.Default).WithId("InProcess"),
Job.Dry.WithToolchain(InProcessEmitToolchain.Default).WithId("InProcess"),
]
);
string snapshotDirectory = Path.Combine(Directory.GetCurrentDirectory(), "BenchmarkDotNet.Artifacts", "snapshots");
Expand Down
7 changes: 3 additions & 4 deletions ...kDotNet.IntegrationTests/DotTraceTests.cs → ...ationTests.ManualRunning/DotTraceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
using Xunit;
using Xunit.Abstractions;

namespace BenchmarkDotNet.IntegrationTests
namespace BenchmarkDotNet.IntegrationTests.ManualRunning
{
public class DotTraceTests : BenchmarkTestExecutor
{
Expand All @@ -29,9 +29,8 @@ public void DotTraceSmokeTest()

var config = new ManualConfig().AddJob(
[
Job.Dry.WithId("ExternalProcess")
// TODO: Add InProcessEmitToolchain job when flaky test issue is resolved https://github.com/dotnet/BenchmarkDotNet/issues/2950
// Job.Dry.WithToolchain(InProcessEmitToolchain.Default).WithId("InProcess")
Job.Dry.WithId("ExternalProcess"),
Job.Dry.WithToolchain(InProcessEmitToolchain.Default).WithId("InProcess")
]
);
string snapshotDirectory = Path.Combine(Directory.GetCurrentDirectory(), "BenchmarkDotNet.Artifacts", "snapshots");
Expand Down
2 changes: 0 additions & 2 deletions tests/BenchmarkDotNet.IntegrationTests/BenchmarkDotNet.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
<ProjectReference Include="..\BenchmarkDotNet.IntegrationTests.Static\BenchmarkDotNet.IntegrationTests.Static.csproj" />
<ProjectReference Include="..\BenchmarkDotNet.Tests\BenchmarkDotNet.Tests.csproj" />
<ProjectReference Include="..\..\src\BenchmarkDotNet\BenchmarkDotNet.csproj" />
<ProjectReference Include="..\..\src\BenchmarkDotNet.Diagnostics.dotTrace\BenchmarkDotNet.Diagnostics.dotTrace.csproj" />
<ProjectReference Include="..\..\src\BenchmarkDotNet.Diagnostics.dotMemory\BenchmarkDotNet.Diagnostics.dotMemory.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
Expand Down