Cleanup | Remove ResourceExposure and ResourceConsumption attributes #3836
+3
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
paulmedynski
left a comment
paulmedynski
left a comment
There was a problem hiding this comment.
One question about the csproj files.
src/Microsoft.Data.SqlClient/src/Interop/Windows/Sni/SniNativeWrapper.cs
Show resolved
Hide resolved
This is never set in Release configuration.
System; System.Runtime.Serialization; System.Security; System.Data; System.Xml; System.Runtime.Caching.
paulmedynski
approved these changes
Dec 11, 2025
Contributor
paulmedynski
left a comment
paulmedynski
left a comment
There was a problem hiding this comment.
Looks great! I love a good deletion PR.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
This pull request has been marked as stale due to inactivity for more than 30 days. If you would like to keep this pull request open, please provide an update or respond to any comments. Otherwise, it will be closed automatically in 7 days. |
github-actions
bot
added
the
Stale
Contributor
Author
|
This PR is not stale. |
github-actions
bot
removed
the
Stale
cheenamalhotra
added
the
Code Health 💊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This cleanup builds on the initial split of System.Data.SqlClient from the rest of netfx. Various methods within the codebase were decorated with
[ResourceExposure]and[ResourceConsumption].These attributes were in turn decorated with
[Conditional("RESOURCE_ANNOTATION_WORK")], which means that they were never compiled into the finished binary unless that conditional compilation symbol was set. It's only set for debug builds, so we don't need to include the attributes. Doing so also removes some unnecessary netfx-specific conditional compilation.Issues
None.
Testing
Test cases continue to pass.