Disable JsonTest since json type is not available on managed instance #3885
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request disables JSON type tests for Azure SQL Managed Instance, which does not support the JSON data type. The changes ensure tests only run on Azure SQL Database where JSON type is available.
Changes:
- Added
IsNotManagedInstancecondition to all 8 test methods inJsonTest.csto exclude them from running on Managed Instance - The implementation is consistent with similar exclusions already applied in other JSON test files (
JsonStreamTest.csandJsonBulkCopyTest.cs)
priyankatiwari08
approved these changes
Jan 13, 2026
Contributor
|
Does the latest 2025 MI not support json?? |
cheenamalhotra
approved these changes
Jan 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/6.1 #3885 +/- ##
===============================================
- Coverage 65.10% 64.22% -0.88%
===============================================
Files 279 279
Lines 53302 53302
===============================================
- Hits 34701 34235 -466
- Misses 18601 19067 +466
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable JsonTest for managed instance that does not support json type.
Issues
AB#41617
Testing
To be enabled if the instance gets upgraded.
Guidelines
Please review the contribution guidelines before submitting a pull request: