[6.1] Port #3828 to release/6.1 #3886
Open
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ports changes from #3828 to the release/6.1 branch to fix CodeCov upload issues in Azure DevOps pipelines. The changes make the code coverage upload behavior configurable via a pipeline variable instead of using a default value.
Changes:
- Removed the default value for the
uploadparameter in the code coverage job template, making it an explicitly required parameter - Added configuration in the core CI pipeline to control upload behavior via the
ci_var_uploadTestResultpipeline variable with comprehensive documentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/dotnet-sqlclient-ci-core.yml | Adds upload parameter configuration with pipeline variable check and documentation comments explaining the requirement |
| eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml | Removes default value for upload parameter, making it explicitly required by callers |
paulmedynski
approved these changes
Jan 13, 2026
samsharma2700
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port #3828 to release/6.1 to fix codeCov upload issues observed in ADO.
Issues
AB#41642
Guidelines
Please review the contribution guidelines before submitting a pull request: