Skip to content

Conversation

@paulmedynski
Copy link
Contributor

We seem to be skipping any tests that require Integrated Security. Our PR/CI pipelines appear to intend to use an Azure DevOps Library variable $(SupportsIntegratedSecurity), which is always true, but the tests still aren't running. I have forced this value to true in the pipelines themselves, and we will see what happens...

Copilot AI review requested due to automatic review settings January 13, 2026 19:58
@paulmedynski paulmedynski added Area\Tests Issues that are targeted to tests or test projects Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. labels Jan 13, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This draft PR investigates why Integrated Security tests are being skipped in the CI/CD pipeline. The author suspects that the Azure DevOps Library variable $(SupportsIntegratedSecurity) isn't being properly resolved, even though it should always be true. The PR hardcodes this value to true in the pipeline configuration to test whether this resolves the issue.

Changes:

  • Hardcoded SupportsIntegratedSecurity: true in 6 test configurations that use local SQL Server instances (SQL 2019 x64, SQL 2019 x86, SQL 2022 x64, SQL 2022 x86, SQL 2022 named instance, and Always Encrypted tests)

AzureKeyVaultUrl: $(AzureKeyVaultUrl)
AzureKeyVaultTenantId: $(AzureKeyVaultTenantId)
SupportsIntegratedSecurity: $(SupportsIntegratedSecurity)
SupportsIntegratedSecurity: true
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a spelling error in the PR title. "Seciruty" should be "Security".

Copilot uses AI. Check for mistakes.
AzureKeyVaultUrl: $(AzureKeyVaultUrl)
AzureKeyVaultTenantId: $(AzureKeyVaultTenantId)
SupportsIntegratedSecurity: $(SupportsIntegratedSecurity)
SupportsIntegratedSecurity: true
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding configuration values like this removes flexibility and makes it difficult to override this setting for different environments or test scenarios. While this change is appropriate for investigating why tests are being skipped, for a production solution consider:

  1. Investigating why the Azure DevOps Library variable $(SupportsIntegratedSecurity) isn't being properly resolved
  2. Ensuring the variable is correctly set in the 'ADO Test Configuration Properties' variable group
  3. If the variable needs to always be true for these local SQL Server configurations, document this requirement

Since this is marked as a DRAFT PR for experimentation, this approach is acceptable for testing purposes, but shouldn't be merged as-is.

Suggested change
SupportsIntegratedSecurity: true
SupportsIntegratedSecurity: $(SupportsIntegratedSecurity)

Copilot uses AI. Check for mistakes.
@paulmedynski paulmedynski changed the title [DRAFT] Integrated Seciruty Tests [DRAFT] Integrated Security Tests Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. Area\Tests Issues that are targeted to tests or test projects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants