Merged
Conversation
Member
Author
|
@luisquintanilla I'm unsure how the API reference should be fixed, I can't find out when/where these files were moved. Check dotnet/ml-api-docs#142 for the build warnings. |
Member
Author
|
Pinging @luisquintanilla |
Contributor
|
@Youssef1313 I think the line numbers may have shifted, so the rendering doesn't look right. |
Member
Author
|
@luisquintanilla I fixed the line numbers, and also other minor fixes. |
luisquintanilla
approved these changes
Aug 27, 2020
Contributor
luisquintanilla
left a comment
luisquintanilla
left a comment
There was a problem hiding this comment.
Wow! That was fast. This looks good to me. Approving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build warnings introduced by dotnet/machinelearning-samples#839
ML.NET API reference is now broken too, https://docs.microsoft.com/en-us/dotnet/api/microsoft.ml.staticpipe.countfeatureselectorstaticextensions.selectfeaturesbasedoncount?view=ml-dotnet-preview-0.14.0.
All examples shows a warning: "It looks like the sample you are looking for has moved! Rest assured we are working on resolving this."
Preview Link