Support winrt consumption using CsWinRT reference#1243
Conversation
|
Waiting for try-convert PR to get merged. |
brandonh-msft
left a comment
brandonh-msft
left a comment
There was a problem hiding this comment.
Overall LGTM just added a few suggestions
...t.DotNet.UpgradeAssistant.Extensions.Windows/UWPtoWinAppSDKUpgrade/WinUIPropertiesUpdater.cs
Show resolved
Hide resolved
...t.DotNet.UpgradeAssistant.Extensions.Windows/UWPtoWinAppSDKUpgrade/WinUIPropertiesUpdater.cs
Outdated
Show resolved
Hide resolved
...t.DotNet.UpgradeAssistant.Extensions.Windows/UWPtoWinAppSDKUpgrade/WinUIPropertiesUpdater.cs
Outdated
Show resolved
Hide resolved
brandonh-msft
requested review from
a team and
brandonh-msft
and removed request for
manodasanW
|
Just merged t-c into |
src/common/Microsoft.DotNet.UpgradeAssistant.Abstractions/IProject.cs
Outdated
Show resolved
Hide resolved
src/components/Microsoft.DotNet.UpgradeAssistant.MSBuild/MSBuildProject.cs
Outdated
Show resolved
Hide resolved
brandonh-msft
left a comment
brandonh-msft
left a comment
There was a problem hiding this comment.
LGTM! Just blocking until another UWP SME gives it the 👍🏻👍🏻
...t.DotNet.UpgradeAssistant.Extensions.Windows/UWPtoWinAppSDKUpgrade/WinUIPropertiesUpdater.cs
Outdated
Show resolved
Hide resolved
...t.DotNet.UpgradeAssistant.Extensions.Windows/UWPtoWinAppSDKUpgrade/WinUIPropertiesUpdater.cs
Outdated
Show resolved
Hide resolved
...t.DotNet.UpgradeAssistant.Extensions.Windows/UWPtoWinAppSDKUpgrade/WinUIPropertiesUpdater.cs
Outdated
Show resolved
Hide resolved
...t.DotNet.UpgradeAssistant.Extensions.Windows/UWPtoWinAppSDKUpgrade/WinUIPropertiesUpdater.cs
Show resolved
Hide resolved
...t.DotNet.UpgradeAssistant.Extensions.Windows/UWPtoWinAppSDKUpgrade/WinUIPropertiesUpdater.cs
Outdated
Show resolved
Hide resolved
| public const string RuleID = "UA302"; | ||
|
|
||
| private const string CsWinRTLogMessageFormat = "A CsWinRTIncludes property with value {0} has been added.\n" + | ||
| "If your project assembly name differs from {0}, update this value with the assembly name.\n" + |
There was a problem hiding this comment.
Is this message printed for the component scenario where the project assembly name comes into play or is it printed for the vcxproj references scenario?
There was a problem hiding this comment.
This is printed for all the vcxproj scenarios (There seems to be no good way to parse the assembly name as we are unable to load cpp projects). So, whenever we add a CsWinRTIncludes property with the name same as the vcxproj file name, we show this message on the console.
3 participants
This PR adds support for CsWinRT consumption in UWP converted projects containing any reference to "vcxproj" projects. We add a CsWinRT reference and CsWinRTIncludes property for each vcxproj reference.