-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Revert "Revert "Move hosting tests to XUnit 3"" #121072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d80eb41
3776409
65712b9
0006982
66eefa8
81583df
692434c
545e239
23a3658
5d0d11d
baa9911
b848f08
f33fb17
ffe3990
6399ed9
ffe6b41
becf07b
5fdc34e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,9 @@ | ||
| <Project> | ||
| <Import Project="$(RepositoryEngineeringDir)liveBuilds.targets" /> | ||
| <Import Project="$(RepositoryEngineeringDir)targetingpacks.targets" /> | ||
|
|
||
| <Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.targets, $(MSBuildThisFileDirectory)..))" /> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @agocke this change looks wrong. Now these projects don't import the parent Directory.Build.targets file anymore but still the parent Directory.Build.props file.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I noticed this as part of #121853 as properties like
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No I think that’s right. These are test assets. I don’t think they should be importing the upwards targets file
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It may be possible to import a specific targets file that provides a minimum set of functionality that we think should apply to tests, but the whole point of these projects is that they should be "normal" .NET projects that an everyday user would see. We do not want our targets files arbitrarily polluting their space.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Then they shouldn't even import any of the upwards props files. They must work without any of our custom defined settings. Also some of our props files must even have targets in them. I think you get my point. We need to be in synchronicity between D.B.props and D.B.targets.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that's probably right -- I didn't realize they import the props files. They shouldn't do that either.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| <PropertyGroup> | ||
| <UseAppHost Condition="'$(UseAppHost)' == '' and '$(SelfContained)' != 'true'">false</UseAppHost> | ||
| <UseAppHost Condition="'$(SelfContained)' != 'true'">false</UseAppHost> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- Override target from targetingpacks.targets. Use Version instead of ProductVersion (written into runtimeconfig.json). | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.