Skip to content

Fix Tar cleanup one-liners #131672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alinpahontu2912 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Draft

Fix Tar cleanup one-liners #131672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarEntry.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ public abstract partial class TarEntry
// Throws on Windows. Block devices are not supported on this platform.
private void ExtractAsBlockDevice(string destinationFileName)
{
Debug.Assert(EntryType is TarEntryType.BlockDevice or TarEntryType.CharacterDevice);
Debug.Assert(EntryType is TarEntryType.BlockDevice);
throw new InvalidOperationException(SR.IO_DeviceFiles_NotSupported);
}

// Throws on Windows. Character devices are not supported on this platform.
private void ExtractAsCharacterDevice(string destinationFileName)
{
Debug.Assert(EntryType is TarEntryType.BlockDevice or TarEntryType.CharacterDevice);
Debug.Assert(EntryType is TarEntryType.CharacterDevice);
throw new InvalidOperationException(SR.IO_DeviceFiles_NotSupported);
}

Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ private int WriteCommonFields(Span<byte> buffer, TarEntryType actualEntryType)

// Calculates how many data bytes should be written, depending on the position pointer of the stream.
// Only works if the stream is seekable.
public long GetTotalDataBytesToWrite()
internal long GetTotalDataBytesToWrite()
{
if (_dataStream == null)
{
Expand Down
Loading